Skip to content

List detail no placeholder #87

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 22 commits into
base: main
Choose a base branch
from
Open

List detail no placeholder #87

wants to merge 22 commits into from
+524 −6

Conversation

tiwiz
Copy link
Contributor

@tiwiz tiwiz commented Oct 2, 2025

Screen_recording_20251002_155559

@gemini-code-assist Gemini Code Assist
Copy link
Contributor

Summary of Changes

Hello @tiwiz, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request adds a new recipe to the project, showcasing an adaptive list-detail pattern that intelligently manages screen real estate without relying on a placeholder. The implementation dynamically adjusts the layout, specifically the number of columns in the list, to optimize for various window sizes, providing a responsive user experience.

Highlights

  • New Adaptive Layout Example: Introduces a "List-Detail without placeholder" example demonstrating adaptive UI based on window size, optimizing content display for various screen configurations.
  • Dynamic Column Adjustment: The new example dynamically adjusts the number of columns in the list view based on the available composable width, enhancing responsiveness.
  • Dependency Updates: Added androidx.window and androidx.window-core dependencies to support advanced window management and adaptive layouts.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

gemini-code-assist[bot]
gemini-code-assist bot reviewed Oct 2, 2025
View reviewed changes
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces a new recipe for a list-detail layout without a placeholder, which is a great addition. However, there are several issues that need to be addressed. There is a consistent typo ('listdeailnoplaceholder' instead of 'listdetailnoplaceholder') across new files, package names, and documentation that should be corrected for clarity and maintainability. An IDE-specific file (.idea/vcs.xml) has been included in the commit and should be removed. More critically, there's a bug in the navigation logic that breaks the back button functionality in the three-pane layout, and a potential crash due to unsafe access to the navigation back stack. My review includes suggestions to fix these issues.

@tiwiz
Copy link
Contributor Author

tiwiz commented Oct 2, 2025

Screen_recording_20251002_174310

@tiwiz
Copy link
Contributor Author

tiwiz commented Oct 6, 2025

Screen_recording_20251006_111624

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dturner dturner Awaiting requested review from dturner dturner is a code owner

@jbw0033 jbw0033 Awaiting requested review from jbw0033 jbw0033 is a code owner

@claraf3 claraf3 Awaiting requested review from claraf3 claraf3 is a code owner

@ianhanniballake ianhanniballake Awaiting requested review from ianhanniballake ianhanniballake is a code owner

1 more reviewer

@gemini-code-assist gemini-code-assist[bot] gemini-code-assist[bot] left review comments

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@tiwiz